Skip to content
This repository was archived by the owner on Jun 1, 2022. It is now read-only.

fix: update query conditions for logs#422

Merged
Fine0830 merged 8 commits intoapache:masterfrom
Fine0830:bugfix/logs
Jan 29, 2021
Merged

fix: update query conditions for logs#422
Fine0830 merged 8 commits intoapache:masterfrom
Fine0830:bugfix/logs

Conversation

@Fine0830
Copy link
Member

Update query conditions for logs.
Reference apache/skywalking#6276

Signed-off-by: Qiuxia Fan qiuxiafan@apache.org

@Fine0830 Fine0830 added bug Something isn't working enhancement New feature or request labels Jan 29, 2021
@Fine0830 Fine0830 added this to the 8.4.0 milestone Jan 29, 2021
@Fine0830 Fine0830 requested review from rainbend and wu-sheng January 29, 2021 03:24
@Fine0830 Fine0830 self-assigned this Jan 29, 2021
@kezhenxu94
Copy link
Member

kezhenxu94 commented Jan 29, 2021

Besides the changes in this PR, I had to patch this in order to make the UI work after apache/skywalking#6275 , otherwise the request failed with some errors

diff --git a/src/graph/fragments/log.ts b/src/graph/fragments/log.ts
index 163c708..0b55ef8 100644
--- a/src/graph/fragments/log.ts
+++ b/src/graph/fragments/log.ts
@@ -47,7 +47,6 @@ export const QueryServiceLogs = {
           endpointId
           traceId
           timestamp
-          isError
           statusCode
           contentType
           content

@Fine0830
Copy link
Member Author

Besides the changes in this PR, I had to patch this in order to make the UI work after apache/skywalking#6275 , otherwise the request failed with some errors

diff --git a/src/graph/fragments/log.ts b/src/graph/fragments/log.ts
index 163c708..0b55ef8 100644
--- a/src/graph/fragments/log.ts
+++ b/src/graph/fragments/log.ts
@@ -47,7 +47,6 @@ export const QueryServiceLogs = {
           endpointId
           traceId
           timestamp
-          isError
           statusCode
           contentType
           content

Done

traceId
timestamp
isError
statusCode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be removed too based on today's tag system. @arugal @kezhenxu94

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal part LGTM

@wu-sheng
Copy link
Member

We wait for the update of new field removal.

@Fine0830 Fine0830 merged commit fdc29d5 into apache:master Jan 29, 2021
@Fine0830 Fine0830 deleted the bugfix/logs branch January 29, 2021 06:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants