Conversation
wu-sheng
reviewed
Jan 24, 2021
configs/satellite_config.yaml
Outdated
|
|
||
| telemetry: | ||
| namespace: namespaces | ||
| cluster: namespaces |
Member
There was a problem hiding this comment.
What is this renaming for? I also still see namespace1 in the pipe_name. Could you be clear more?
Member
Author
There was a problem hiding this comment.
they are different concepts, one is the cluster concept, such that Namespace in the Kubernetes. Another one is the internal concept, which means running in the different pipes. Please ignore it now, I would add the env override mod later, which is similar withe the SkyWalking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
polish plugins for e2e test