Merged
Conversation
EvanLjp
requested review from
gxthrj,
kezhenxu94,
nic-chen,
surlymo and
wu-sheng
kezhenxu94
reviewed
Jan 30, 2021
kezhenxu94
reviewed
Jan 30, 2021
wu-sheng
reviewed
Jan 30, 2021
nic-chen
reviewed
Jan 31, 2021
gxthrj
reviewed
Jan 31, 2021
| @@ -50,13 +50,13 @@ func cleanBenchmarkQueue(b *testing.B, q api.Queue) { | |||
| } | |||
| } | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Should the file name be benchmark_test.go?
Member
|
ping @EvanLjp |
Member
Author
|
Sorry,recently，i am quite busy on my work，i would force on satellite after tomorrow. |
Member
Author
wu-sheng
reviewed
Feb 8, 2021
wu-sheng
approved these changes
Feb 8, 2021
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
LGTM, we need a lot of polish about the document before our first release.
Member
Author
I will continue to do this from today |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add memory queue, please pay attention to the concurrency problem
https://github.com/apache/skywalking/issues?q=is%3Aopen+mentions%3A%40me