add skywalking-client-js in action#170
Closed
tristan-tsl wants to merge 17 commits intoapache:masterfrom
tristan-tsl:master
Closed
add skywalking-client-js in action#170tristan-tsl wants to merge 17 commits intoapache:masterfrom tristan-tsl:master
tristan-tsl wants to merge 17 commits intoapache:masterfrom
tristan-tsl:master
Conversation
wu-sheng
reviewed
Dec 13, 2020
|
|
||
|
|
||
|
|
||
| 首先我们得明白前端项目是通过Nginx代理出来, 我们得修改Nginx添加SkyWalking-OAP端点, Nginx案例如下(Ingress-Nginx暂略) |
Member
There was a problem hiding this comment.
No background, can't follow the context.
Contributor
Author
There was a problem hiding this comment.
beacause the webfront project in nginx
Member
There was a problem hiding this comment.
Take a look at good example. http://skywalking.apache.org/zh/observe-service-mesh-with-skywalking-and-envoy-access-log-service/
Blog should give a full context about what is going on. Blog is not a replacement of the documentation.
wu-sheng
reviewed
Dec 13, 2020
|
|
||
|  | ||
|
|
||
| 谢谢观看, 我会继续完善这篇文章 No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
This shows up again.
已经更改了, 再看下呗
wu-sheng
reviewed
Dec 14, 2020
wu-sheng
reviewed
Dec 14, 2020
|
|
||
|  | ||
|
|
||
| 谢谢观看, 后续我会在SkyWalking告警这块写更多实战文章 |
Contributor
Author
There was a problem hiding this comment.
描述错误，此文章不是告警文章。请仔细校对文章。
已经修改
wu-sheng
reviewed
Dec 18, 2020
|
|
||
| https://github.com/apache/skywalking-client-js | ||
|
|
||
| 谢谢观看, 后续我会在SkyWalking-client-js这块写更多实战文章 |
wu-sheng
reviewed
Dec 18, 2020
|
|
||
|
|
||
|
|
||
| 首先我们前端项目是通过Nginx代理出来。我们需要修改Nginx添加SkyWalking-OAP端点, 让SkyWalking-OAP可以被浏览器访问到。我们的Nginx配置如下(Ingress-Nginx暂略) |
wu-sheng
reviewed
Dec 18, 2020
Comment on lines
+12
to
+18
| ``` | ||
| location /browser { | ||
| proxy_pass http://<your_skywalking_oap_ip>:12800; | ||
| proxy_set_header Host $host; | ||
| proxy_set_header X-Real-IP $remote_addr; | ||
| } | ||
| ``` |
wu-sheng
reviewed
Dec 18, 2020
| ``` | ||
| import ClientMonitor from 'skywalking-client-js' | ||
|
|
||
| const router = createRouter() // 在router创建之后 |
Member
There was a problem hiding this comment.
createRouter 是vue相关语法，文章并没有做相应的交代。
wu-sheng
reviewed
Dec 18, 2020
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
文章缺少连贯性，需要增强相关内容。官方blog不是练习笔记，我们要求完善的内容、章节、实例图等。
Contributor
Author
|
好的
吴晟 Wu Sheng <notifications@github.com> 于2020年12月18日周五 下午8:25写道：
… ***@***.**** commented on this pull request.
文章缺少连贯性，需要增强相关内容。官方blog不是练习笔记，我们要求完善的内容、章节、实例图等。
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#170 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALEWV4BIFM3AKELM6RNTXVLSVNC35ANCNFSM4UZP7O6Q>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add skywalking-client-js in action