Skip to content

Conversation

@mrproliu
Copy link
Contributor

@mrproliu mrproliu commented Sep 6, 2021

No description provided.

@mrproliu mrproliu added the chore Project chores label Sep 6, 2021
@kezhenxu94
Copy link
Member

Check the preview https://deploy-preview-324--skywalking-preview.netlify.app/ it links to the main repo doc

@mrproliu
Copy link
Contributor Author

mrproliu commented Sep 6, 2021

Check the preview https://deploy-preview-324--skywalking-preview.netlify.app/ it links to the main repo doc

Has been fixed, the infra-e2e documentation has some link could not fount in the website, I will create another PR in the infra-e2e project to fix it.

@wu-sheng wu-sheng closed this Sep 6, 2021
@wu-sheng wu-sheng reopened this Sep 6, 2021
@wu-sheng
Copy link
Member

wu-sheng commented Sep 6, 2021

2 menu items are still 404.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 6, 2021

image

This is useless, please remove it.

Others are

  1. set up should be Setup
  2. configuration should have C in upper case.
  3. Compiling guidance should be in a separate menu(Contribution), because actually users don't care about compiling at all.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 6, 2021

Also, send a pull request to api7's repo. Take a reference from mine, api7/contributor-graph#95.
We need to count the contributors of e2e-infra project.

@mrproliu
Copy link
Contributor Author

mrproliu commented Sep 6, 2021

  1. set up should be Setup

Should we just rename Guide to Setup, reduce one menu level?

@wu-sheng
Copy link
Member

wu-sheng commented Sep 6, 2021

Should we just rename Guide to Setup, reduce one menu level?

Yes, should be . And Setup is one word.

@mrproliu mrproliu closed this Sep 6, 2021
@mrproliu mrproliu reopened this Sep 6, 2021
@wu-sheng wu-sheng merged commit 243d1f2 into apache:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Project chores

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants