Conversation
✅ Deploy Preview for skywalking-website-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
content/quickstart-docker.ps1
Outdated
| Write-Host " -d Run in background mode (docker compose up -d)" | ||
| Write-Host " -f Run in foreground mode (docker compose up)" |
There was a problem hiding this comment.
Can we only keep one of these options? For a Boolean option I don't think it necessary to provide 2 options
There was a problem hiding this comment.
Ok, removed. It was put there to allow non-interative runs.
There was a problem hiding this comment.
I can't see commits today. Do you miss it?
There was a problem hiding this comment.
I can't see commits today. Do you miss it?
Just pushed, was having hotpot at home 😆
content/quickstart-docker.ps1
Outdated
| Write-Host "Docker is installed, continue...`n" | ||
|
|
||
| # In place download | ||
| Invoke-WebRequest -Uri "https://github.com/apache/skywalking/raw/master/docker/docker-compose.yml" -OutFile ".\docker-compose.yml" |
There was a problem hiding this comment.
You download the file to the current directory, let's either move it to a temporary folder or check whether current directory already has a file with the same name in case we override user's file unexpectedly
There was a problem hiding this comment.
Added new logic to allow user to choose the override behavior, bevause temp dir on windows won't be cleared automatically so I figured some people might not like that. (and its hard to say if the temp dir logic will work on all systems)
3 participants
This is an equivalent quick start script for Windows (powershell).
Functionality has been tested on my Windows laptop. A new section will be added to the OAP doc to cover its usage.
It could be excuted using:
Can be run with or without interaction:
