-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Closed
Milestone
Description
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- Question or discussion
- Bug
- Requirement
- Feature or performance improvement
Requirement or improvement
As discussed in PR #5357 , any constant class members MUST only contain capital characters, numbers and _, except that it can be named as logger.
The related code is listed below,
skywalking/apm-checkstyle/checkStyle.xml
Line 82 in bcc27eb
| <property name="format" value="(^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$)|(^logger)"/> |
We reach an agreement that this additional rule should be removed and the code should be adapted to the new style.
A new PR has to be created to focus on this issue. Also, this new PR should be merged before #5357 .
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels