Skip to content

Allow multiple definitions as fallback in metadata-service-mapping.yaml file #6901

@sergicastro

Description

@sergicastro

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Requirement or improvement

Regarding the metadata-service-mapping.yaml file used to configure which fields/labels are used to extract required data, would be nice to provide a way to configure multiple values treated as a fallback mechanism to extract the required data.

For example, let's say I want to extract the service name from the label service.istio.io/canonical-name but I want to fall back into app.kubernetes.io/name or app labels if the first one is not defined.
Allowing a comma-separated value in the config file would be enough to what needs to be processed to find the service name in this case.
The config file would look like this:

serviceName: ${LABELS."service.istio.io/canonical-name"},${LABELS."app.kubernetes.io/name"},${LABELS."app"}
serviceInstanceName: ${NAME}

This is just a suggestion, any other implementation covering the requirement is welcome.

Metadata

Metadata

Labels

backendOAP backend related.enhancementEnhancement on performance or codes

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions