The problem remains : NPE when thrift field is nested

[lzdujing]

Please answer these questions before submitting your issue.

• Why do you submit this issue?
• [ T] Question or discussion
• Bug
• Requirement
• Feature or performance improvement

---

Question

• What do you want to know?
  I already used version 8.6.0 which has fixed the error: NPE when thrift field is nested ,but context is still null, why?

---

Bug

• Which version of SkyWalking, OS, and JRE?
  8.6.0

• Which company or project?

• What happened?
  If possible, provide a way to reproduce the error. e.g. demo application, component version.

context is null, why?

code position:

ServerInProtocolWrapper#readFieldBegin()
    @Override
    public TField readFieldBegin() throws TException {
       ................
        if (field.type == TType.STOP) {
            Boolean haveCreatedSpan =
                    (Boolean) ContextManager.getRuntimeContext().get(HAVE_CREATED_SPAN);
            if (haveCreatedSpan != null && !haveCreatedSpan) {
                try {
                    AbstractSpan span = ContextManager.createEntrySpan(
                            context.getOperatorName(), createContextCarrier(null));
                    span.start(context.startTime);
                    span.tag(TAG_ARGS, context.getArguments());
                    span.setComponent(ComponentsDefine.THRIFT_SERVER);
                    SpanLayer.asRPCFramework(span);
                } catch (Throwable throwable) {
                    LOGGER.error("Failed to create EntrySpan.", throwable);
                } finally {
                    context = null;
                }

        return field;
    }

---

Requirement or improvement

• Please describe your requirements or improvement suggestions.

[wu-sheng]

Please share the demo codes and error stack

[lzdujing]

This error happened when my ThriftServer is resigister to nacos。If it not resigister to nacos，the problem not appeared.

[lzdujing]

this code is never executed , so ,context is null forever.

public void initial(AbstractContext context) {
this.context = context;
ContextManager.getRuntimeContext().put(HAVE_CREATED_SPAN, false);
}

[wu-sheng]

Please at least share the runnable demo codes with us, including how to run the codes locally. Your description is hard/impossible to follow for us.

[lzdujing]

ok，I prepared later.

[lzdujing]

Hello, Wu Zong, I haved uploaded demo codes and description document to the github. Thank you for following it very much!
https://github.com/KeJemas/thriftDemo

[wu-sheng]

@dmsolr Could you take a look when you have time?

[dmsolr]

Sure. I will try to reproduce this issue.

[lzdujing]

@dmsolr Can this issue be reproduced?

[dmsolr]

@lzdujing Sorry. A tittle busy these days. I will do this on weekend.

[lzdujing]

@dmsolr ok,thank you.

[lzdujing]

@dmsolr Could you take a look this issue for me sometime soon? We are waiting to solve the problem a little worry . Thank you.