[Feature] python gRPC plugin

[kehuili]

Search before asking

• I had searched in the issues and found no similar feature requirement.

Description

I have implemented a gRPC plugin for python, and interceptors(client-side and server-side) were used to achieve this.

But in developer guide and plugins already implemented, it seems to be a different way to implement a plugin.

Inside the install method, you find out the relevant method(s) of the libraries that you plan to instrument, and create/close spans before/after those method(s).

I was wondering if I make a PR, is interceptors acceptable, or it is a better way to follow what's said in developer guide.

Use case

Use python gRPC plugin to track gRPC requests

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[wu-sheng]

Inside the install method, you find out the relevant method(s) of the libraries that you plan to instrument, and create/close spans before/after those method(s).

This is general guidance, not a strict rule.

Usually, it is also common to intercept or implement filters to get the same purpose. The key point is, your plugin should be auto instrumentation, don't need to change the target service's source codes.

[kezhenxu94]

I was wondering if I make a PR, is interceptors acceptable, or it is a better way to follow what's said in developer guide.

If I understand correctly, you mean you have interceptors that users can use in their code, but SkyWalking Python agent aims to do the interception automatically, so I think what you need is to find out a proper point and insert your interceptors (automatically) into the process chain

[kezhenxu94]

@kehuili you can see the same method in our Java agent, we have interceptor and a point to insert that interceptor automatically.

[kehuili]

Got it. Gonna find a proper way to implement it.

[wu-sheng]

Got it. Gonna find a proper way to implement it.

If this is not ready yet, should we move this to the discussion channel?

[kehuili]

If this is not ready yet, should we move this to the discussion channel?

Sure.