Skip to content

Cache enhancement - don't read new metrics from database in minute #10085

Merged
wu-sheng merged 3 commits intomasterfrom
enhance-cache
Dec 5, 2022
Merged

Cache enhancement - don't read new metrics from database in minute #10085
wu-sheng merged 3 commits intomasterfrom
enhance-cache

Conversation

@wu-sheng
Copy link
Member

@wu-sheng wu-sheng commented Dec 5, 2022

Through this PR, the metrics in minutes would mostly not read metrics from the database anymore. This should be able to be observed in by so11y's metrics_persistent_cache.

@wu-sheng wu-sheng added core feature Core and important feature. Sometimes, break backwards compatibility. backend OAP backend related. enhancement Enhancement on performance or codes labels Dec 5, 2022
@wu-sheng wu-sheng added this to the 9.4.0 milestone Dec 5, 2022
// When
// (1) the time bucket of the server's latest stability status is provided
// 1.1 the OAP has booted successfully
// 1.2 the current dimensionality is in minute.
Copy link
Member Author

@wu-sheng wu-sheng Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wankai123 1.3 should be related to #10076

1.3 the OAP cluster is rebalanced due to scaling

Copy link
Member

@wankai123 wankai123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. core feature Core and important feature. Sometimes, break backwards compatibility. enhancement Enhancement on performance or codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] [OAP] Consider removing metrics reload in persistent

2 participants