Conversation
Notice, no HTTPS/TLS setup support. By following AWS Firehose request, it uses [proxy request](https://en.wikipedia.org/wiki/Proxy_server#Web_proxy_servers) (`https://...` instead of `/aws/firehose/metrics`), there must be a proxy(Nginx, Envoy, etc.).
Member
Author
|
Upstream discussion on Armeria to locate this. https://line-armeria.slack.com/archives/C1NGPBUH2/p1676811880163349 |
6 tasks
Member
Author
|
Debug logs from @pg-yang |
Member
|
We should remove the configurations from skywalking/oap-server/server-starter/src/main/resources/application.yml Lines 558 to 560 in cabe40e |
kezhenxu94
reviewed
Feb 19, 2023
Member
kezhenxu94
left a comment
There was a problem hiding this comment.
Configs in yaml file should be removed too
Member
|
And configuration-vocabulary.md |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Notice, no HTTPS/TLS setup support. By following AWS Firehose request, it uses proxy request (
https://...instead of/aws/firehose/metrics), there must be a proxy(Nginx, Envoy, etc.).CHANGESlog.@pg-yang I think we need to update Firehose and S3 document to add a proxy requirement in the metrics forward path