Skip to content

Support Monitoring DynamoDB.#10418

Merged
wu-sheng merged 6 commits intoapache:masterfrom
yswdqz:dynamodb-1
Feb 21, 2023
Merged

Support Monitoring DynamoDB.#10418
wu-sheng merged 6 commits intoapache:masterfrom
yswdqz:dynamodb-1

Conversation

@yswdqz
Copy link
Copy Markdown
Member

@yswdqz yswdqz commented Feb 20, 2023

  • If this is non-trivial feature, paste the links/URLs to the design doc.

  • Update the documentation to include this new feature.

  • Tests(including UT, IT, E2E) are added to verify the new feature.

  • If it's UI related, attach the screenshots below.

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.

  • Update the CHANGES log.

image
image
image
image

@yswdqz yswdqz added backend OAP backend related. enhancement Enhancement on performance or codes AWS AWS Infrastructure Monitoring labels Feb 20, 2023
Comment on lines +12 to +13
Note that AWS requires that the `HTTP Endpoint URL` must be through HTTPS listening at 443, therefore need to load the certificate in [aws-firehose-receiver](aws-firehose-receiver.md) and set the port to 443.
Or, you can use another gateway to accept the requests and route them to `aws-filehose-receiver`.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a proxy as always. And we don't need to mention this part again, as firehose receiver doc includes this before.

Comment on lines +14 to +15
3. Create a [metric stream](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch-Metric-Streams.html), set namespace to DynanoDB, and set `Kinesis Data Firehose` to the firehose you just created.
4. Config [aws-firehose-receiver](aws-firehose-receiver.md) to receive data.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could refer s3 document, the most important part of this doc is for pointing to AWS docs about how to setup firehose for DynamoDB, and forward to OAP.

@wu-sheng
Copy link
Copy Markdown
Member

Should we put inspections as the tab0? Usually we want to see general metrics first, then to check for table by table.

@yswdqz
Copy link
Copy Markdown
Member Author

yswdqz commented Feb 20, 2023

Got it.

@yswdqz
Copy link
Copy Markdown
Member Author

yswdqz commented Feb 20, 2023

Now it is ok.
image

@wu-sheng wu-sheng added this to the 9.4.0 milestone Feb 20, 2023
Copy link
Copy Markdown
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit f6ef55b into apache:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AWS AWS Infrastructure Monitoring backend OAP backend related. enhancement Enhancement on performance or codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants