Skip to content

Conversation

@kezhenxu94
Copy link
Member

@wu-sheng wu-sheng added this to the 9.5.0 milestone May 15, 2023
@wu-sheng wu-sheng added backend OAP backend related. logging Log collecting and analysis feature New feature labels May 15, 2023
@kezhenxu94 kezhenxu94 changed the title Otlp/logs Add OpenTelemetry log protocol support May 16, 2023
@kezhenxu94 kezhenxu94 marked this pull request as ready for review May 17, 2023 05:10
@kezhenxu94 kezhenxu94 force-pushed the otlp/logs branch 2 times, most recently from 69d4478 to c21b475 Compare May 17, 2023 05:19
@wu-sheng
Copy link
Member

wu-sheng commented May 17, 2023

log-otlp.md should be updated according to, especially about

  1. Highlighting the OTLP native logging is supported. And add docs about setting up log analysis rules, as well as ref to LAL doc.
  2. OLTP SkyWalking log exporter is optional for now.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

enabledHandlers: ${SW_OTEL_RECEIVER_ENABLED_HANDLERS:"otlp-metrics,otlp-logs"}
```

Also, because most of the language SDKs of OpenTelemetry do not support logging feature (yet) or the logging feature is
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said, many of the language SDKs don't support logging feature yet or are experimental stage now, we will need more improvements in the future when they support logging

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have to work with OTEL SDKs/Agents anyway. Abou that OTEL, we are always only adopting as much as possible no matter where the source is from and how the format is built.
There are always a group of people who would think the OTEL is somehow a standard or much more meaningful than the other formats.
But from my personal perspective and experiences, there is nothing new there. The metrics format is from Prometheus, the Trace format is from Zipkin, and logs are easy generally text only.

All the points of this kind of support are, we could leverage some existing integrations, which the OTEL community would do. That is the only benefit.

Don't worry whether their agents are supporting or not. The lessons I learned from OT are, these APIs would have special values when they are stale(not updated anymore). Ironically, but true.

@wu-sheng wu-sheng merged commit fc2eced into apache:master May 18, 2023
@kezhenxu94 kezhenxu94 deleted the otlp/logs branch May 18, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. feature New feature logging Log collecting and analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support OTLP Native Logging

2 participants