-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Add OpenTelemetry log protocol support #10808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
69d4478 to
c21b475
Compare
|
|
wu-sheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| enabledHandlers: ${SW_OTEL_RECEIVER_ENABLED_HANDLERS:"otlp-metrics,otlp-logs"} | ||
| ``` | ||
|
|
||
| Also, because most of the language SDKs of OpenTelemetry do not support logging feature (yet) or the logging feature is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As said, many of the language SDKs don't support logging feature yet or are experimental stage now, we will need more improvements in the future when they support logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have to work with OTEL SDKs/Agents anyway. Abou that OTEL, we are always only adopting as much as possible no matter where the source is from and how the format is built.
There are always a group of people who would think the OTEL is somehow a standard or much more meaningful than the other formats.
But from my personal perspective and experiences, there is nothing new there. The metrics format is from Prometheus, the Trace format is from Zipkin, and logs are easy generally text only.
All the points of this kind of support are, we could leverage some existing integrations, which the OTEL community would do. That is the only benefit.
Don't worry whether their agents are supporting or not. The lessons I learned from OT are, these APIs would have special values when they are stale(not updated anymore). Ironically, but true.
CHANGESlog.