-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Support multiple configs for each hook types and specifying the hooks in the alarm rule. #11137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s.yml`. Support multiple configs for each hook types and specifying the hooks in the alarm rule.
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
...in/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmHookSettings.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/skywalking/oap/server/core/alarm/provider/discord/DiscordHookCallback.java
Show resolved
Hide resolved
.../main/java/org/apache/skywalking/oap/server/core/alarm/provider/webhook/WebhookCallback.java
Show resolved
Hide resolved
Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
| hooks: | ||
| slack: | ||
| default: | ||
| is-global: true # if true, this hook will apply on all rules, unless a rule has its own specific hook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless a rule has its own specific hook.
So, if there are hooks specified in the rules, the is-global is not working.
Am I right? If so, the name global seems not proper, it is more like a default rule. We should consider not to set default as name in the demo, and change this to is-default : true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, if there are hooks specified in the rules, the is-global is not working. Am I right?
yes
If so, the name global seems not proper, it is more like a default rule. We should consider not to set default as name in the demo, and change this to is-default : true
I think is-global means you can define more than one global hook in one type. is-default mostly means only one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But global seems not to be able to be overridden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense, changed
Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
If this is non-trivial feature, paste the links/URLs to the design doc.
Update the documentation to include this new feature.
Tests(including UT, IT, E2E) are added to verify the new feature.
If it's UI related, attach the screenshots below.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
Update the
CHANGESlog.