Skip to content

Conversation

@wankai123
Copy link
Member

  • If this is non-trivial feature, paste the links/URLs to the design doc.

  • Update the documentation to include this new feature.

  • Tests(including UT, IT, E2E) are added to verify the new feature.

  • If it's UI related, attach the screenshots below.

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.

  • Update the CHANGES log.

…s.yml`. Support multiple configs for each hook types and specifying the hooks in the alarm rule.
@wankai123 wankai123 added backend OAP backend related. enhancement Enhancement on performance or codes labels Jul 27, 2023
@wankai123 wankai123 added this to the 9.6.0 milestone Jul 27, 2023
@wankai123 wankai123 requested review from kezhenxu94 and wu-sheng July 27, 2023 02:03
@sonatype-lift
Copy link

sonatype-lift bot commented Jul 27, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

wankai123 and others added 5 commits July 27, 2023 11:10
kezhenxu94
kezhenxu94 previously approved these changes Jul 27, 2023
Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
kezhenxu94
kezhenxu94 previously approved these changes Jul 27, 2023
hooks:
slack:
default:
is-global: true # if true, this hook will apply on all rules, unless a rule has its own specific hook.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless a rule has its own specific hook.

So, if there are hooks specified in the rules, the is-global is not working.
Am I right? If so, the name global seems not proper, it is more like a default rule. We should consider not to set default as name in the demo, and change this to is-default : true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if there are hooks specified in the rules, the is-global is not working. Am I right?

yes

If so, the name global seems not proper, it is more like a default rule. We should consider not to set default as name in the demo, and change this to is-default : true

I think is-global means you can define more than one global hook in one type. is-default mostly means only one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But global seems not to be able to be overridden.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, changed

wankai123 and others added 2 commits July 27, 2023 23:30
Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
@wu-sheng wu-sheng merged commit 9c2376a into apache:master Jul 27, 2023
@wankai123 wankai123 deleted the alarm-hooks branch July 28, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. enhancement Enhancement on performance or codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants