Check results in ALS as per downstream/upstream instead of per log#11265
Conversation
kezhenxu94
added
backend
| return metrics.getHttpMetrics().getMetricsCount() > 0 | ||
| || metrics.getTcpMetrics().getMetricsCount() > 0; |
There was a problem hiding this comment.
Should this be hasDownstreamMetrics || hasUpstreamMetrics?
There was a problem hiding this comment.
This is for sidecar analysis, for logs from sidecar. It doesn't care about upstream or downstream. It just cares about whether there is matrics or not.
There was a problem hiding this comment.
But I can do it to unify the condition to check whether there is metrics
There was a problem hiding this comment.
Meanwhile, do hasDownstreamMetrics/hasUpstreamMetrics have meanings when do sidecar analysis?
I am trying to get variable more accurate.
There was a problem hiding this comment.
Yes, you can make sense of the names: for server sidecar there is always only downstream metrics, for client sidecar there is always only upstream metrics.
|
The CI seems broken. Please fix them. |
2 participants
CHANGESlog.Currently the mesh analyzer plugins are invoked on every piece of log, and the plugin chain is terminated as soon as any metrics data is extracted from an previous plugin, this is fine if the upstream/downstream from the log both have or have no metadata, then both side can be analyzed in mx plugin or k8s IP mapping plugin, but if one side has metadata and the other side needs k8s IP mapping plugin, the latter will be skipped as the mx plugin already has part of the metrics, this patch will determine the upstream/downstream metrics are extracted or not, and fallback to the next plugin to extract the missing metrics.