Skip to content

Fix inaccuracy nginx service metrics.#12096

Merged
wu-sheng merged 1 commit intoapache:masterfrom
weixiang1862:nginx-multiple-label
Apr 12, 2024
Merged

Fix inaccuracy nginx service metrics.#12096
wu-sheng merged 1 commit intoapache:masterfrom
weixiang1862:nginx-multiple-label

Conversation

@weixiang1862
Copy link
Member

Fix inaccuracy nginx service metrics.

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

…Remove unused type label in latency metrics.
@weixiang1862
Copy link
Member Author

service metrics:
image

instance1 metrics:
image

instance2 metrics:
image

@wu-sheng wu-sheng requested a review from wankai123 April 12, 2024 08:38
@wu-sheng wu-sheng added this to the 10.0.0 milestone Apr 12, 2024
@wu-sheng wu-sheng added backend OAP backend related. feature New feature labels Apr 12, 2024
Copy link
Member

@wankai123 wankai123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 7a6a19d into apache:master Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Metrics are not aggregated properly as OTEL collector targeting per node

3 participants