Set max attempts for Istio ServiceEntry DNS resolution and do not wait for first result #13235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for first result
wu-sheng
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: The existing logic tries to wait for the first DNS resolution before putting it into the map, but in the case where the DNS is not resolvable at all, it won’t be put in the map and thus each call to the cache will perform a DNS resolution, this can consume all the memory and causes other unrelated threads to fail due to memory pressure.
This PR do the following things:
Put the DNS resolution task to the cache map without waiting for the first result, when the DNS is not resolvable at all, no new task will be created.
Check if the task is completed, try to get the resolved IPs only when then task is completed.
Set max attempts to the DNS resolution, if it failed to resolve the DNS for 3 times, it stop trying.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. NO
Update the
CHANGESlog.