Skip to content

BanyanDB: make BanyanDBMetricsDAO output scan all blocks info log only when the model is not indexModel. #13453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wankai123 merged 2 commits into from
Sep 1, 2025
Merged

BanyanDB: make BanyanDBMetricsDAO output scan all blocks info log only when the model is not indexModel. #13453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74070d1
BanyanDB: make `BanyanDBMetricsDAO` output `scan all blocks` info log…
wankai123 Sep 1, 2025
a7937b2
changs
wankai123 Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/en/changes/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@
| **Attach Listener** | 1 | RUNNABLE | JVM attach listener thread. |
| **Total** | **158** | - | - |

* BanyanDB: make `BanyanDBMetricsDAO` output `scan all blocks` info log only when the model is not `indexModel`.

#### UI

* Enhance the trace `List/Tree/Table` graph to support displaying multiple refs of spans and distinguishing different parents.
Expand Down
4 changes: 3 additions & 1 deletion .../org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBMetricsDAO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ public List<Metrics> multiGet(Model model, List<Metrics> metrics) throws IOExcep
if (begin != 0L || end != 0L) {
timestampRange = new TimestampRange(begin, end);
} else {
log.info("{}[{}] will scan all blocks", model.getName(), idStr);
if (!model.getBanyanDBModelExtension().isIndexMode()) {
log.info("{}[{}] will scan all blocks", model.getName(), idStr);
}
}

List<Metrics> metricsInStorage = new ArrayList<>(metrics.size());
Expand Down
Loading