Skip to content

Conversation

@wankai123
Copy link
Member

@wankai123 wankai123 added this to the 10.3.0 milestone Sep 26, 2025
@wankai123 wankai123 added backend OAP backend related. feature New feature database BanyanDB - SkyWalking native database labels Sep 26, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds namespace support to BanyanDB groups by introducing a configurable prefix for group names. The main purpose is to allow multiple SkyWalking instances to share the same BanyanDB cluster while isolating their data through namespaced group names.

Key changes:

  • Added namespace configuration with default value "sw" in BanyanDB storage config
  • Updated all metadata registry method calls to use specific methods (findMetricMetadata, findRecordMetadata, findManagementMetadata)
  • Modified group name construction to include namespace prefix format: "{namespace}_{group_name}"

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
BanyanDBStorageConfig.java Added namespace field with default value "sw" to global configuration
MetadataRegistry.java Added namespace support to schema metadata and split findMetadata into specific methods
Various DAO files Updated method calls from generic findMetadata to specific typed methods
AbstractBanyanDBDAO.java Added queryTraceDebuggable method and made queryTrace private
BanyanDBStorageClient.java Updated property query methods to use schema-based group resolution
bydb.yml Added namespace configuration documentation and environment variable
changes.md Added changelog entry for the new feature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

wu-sheng
wu-sheng previously approved these changes Sep 26, 2025
@wu-sheng wu-sheng merged commit 2ec8e18 into apache:master Sep 26, 2025
172 of 173 checks passed
@wankai123 wankai123 deleted the group-prefix branch September 26, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. database BanyanDB - SkyWalking native database feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add group prefix for BanyanDB groups

2 participants