Use containsOnce for metadata e2e expected files#13815
Merged
Conversation
Migrate outer-level contains to containsOnce in service, instance, endpoint, and topology expected files (101 files). containsOnce uses backtracking for optimal 1:1 assignment between expected and actual entries, which is more precise for metadata where we know exactly which entries should exist. Inner nested contains (layers, tags, etc.) are left unchanged.
wu-sheng
added
test
wankai123
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use containsOnce for stricter metadata verification in e2e tests
Migrate outer-level
containstocontainsOncein 101 expected files:containsOnceuses backtracking for optimal 1:1 assignment between expected and actual entries, ensuring each actual item matches exactly one expected entry. This is more precise than greedycontainsfor metadata where we know exactly which entries should exist.Inner nested
contains(.layers,.tags, etc.) are left unchanged.Verified locally with the locally-built infra-e2e binary against mock data for service, instance, and topology patterns.
CHANGESlog.