Mask more keywords by default and remove auto generate id for UI templates#13884
Merged
Conversation
wankai123
added
the
chore
There was a problem hiding this comment.
Pull request overview
This PR updates the default secret-masking keyword list used by the status/debugging config dump so that additional keystore-related passwords are redacted by default.
Changes:
- Extend
keywords4MaskingSecretsOfConfigdefault list to includetrustStorePassandkeyStorePass. - Update backend configuration documentation to reflect the new default keyword list.
- Add a changelog entry noting the new default masking behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
oap-server/server-starter/src/main/resources/application.yml |
Updates the shipped default masking keyword list for /debugging/config/dump. |
docs/en/setup/backend/configuration-vocabulary.md |
Updates the documented default value for the masking keyword list. |
docs/en/setup/backend/admin-api/status.md |
Updates the Status API doc example to show the new default masking keywords. |
docs/en/changes/changes.md |
Notes the default masking expansion in the changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wankai123
changed the title
wu-sheng
previously approved these changes
May 26, 2026
wu-sheng
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.