Fix NullPointerException when deserialize tags of span#228
Closed
ascrutae wants to merge 1 commit into
Closed
Conversation
wu-sheng
requested changes
Jun 17, 2017
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
I prefer to fix this by higher performance way. e.g. add get method for reading tags. Initialize all maps cost a log gc and memory. cc @pengys5
Member
|
And this may triggrt UI bug too. Please check it. |
Member
|
Because milestone has been changed. No need to support this. |
lu-xiaoshuang
pushed a commit
to lu-xiaoshuang/skywalking
that referenced
this pull request
Aug 12, 2024
* update witness class in elasticsearch-6.x-plugin * update test cases in elasticsearch-6.x-plugin * update the supported list Co-authored-by: xzy <xiongzheyuan@shouqianba.com>
wu-sheng
added a commit
that referenced
this pull request
Jun 4, 2026
* Migrate e2e admin-API curl calls to swctl admin commands Replace raw curl interactions with the OAP admin-server REST host (port 17128) across the e2e suite with the new 'swctl admin ...' command tree (skywalking-cli #228, commit b447211): - runtime-rule flows (mal/lal/cluster) -> swctl admin runtime-rule ... - dsl-debug flows (oal/mal/lal-block/lal-statement) -> swctl admin dsl-debug ... - ui-management -> swctl admin ui-template ... - storage inspect/config(dump,ttl) -> swctl admin inspect|config ... --display json/yaml keeps response bodies parseable by the existing jq/yq assertions; runtime-rule negative paths assert the CLI's typed error envelope (HTTP <code> (<applyStatus>)). config-dump.yml is regenerated as the JSON string-map that 'admin config dump' returns. Bumps SW_CTL_COMMIT to the admin-capable commit. Non-admin curls (BanyanDB probe, self-telemetry, alarm webhook) are intentionally kept. * e2e: fix swctl admin review feedback (yaml.v2 key casing + missing swctl install) - inspect cases: the CLI marshals typed structs through yaml.v2 (json tags ignored -> lowercased keys scopeid/entityid/mqeentity), which would not match the existing fixtures (scopeId/entityId/mqeEntity). Use '--display json | yq -P' so the json tags are honored and the fixtures stay unchanged. - runtime-rule/cluster and ui-management/banyandb setups now install swctl: both cases newly depend on it (the flows/cases no longer use curl), but their setup only installed jq / yq, so a clean e2e shell would hit 'swctl: command not found'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
Spandoes not havetagsWithBool, the serialization data does not containtagsWithBooldata, and the collector does not initialize thetagsWithBoolfield during deserialize, and it will cause NullPointerException when operationtagsWithBoolfield.