Skip to content

Fix issue 2473#2506

Closed
zhaoyuguang wants to merge 2 commits intoapache:masterfrom
zhaoyuguang:zhaoyuguang/fix-2473
Closed

Fix issue 2473#2506
zhaoyuguang wants to merge 2 commits intoapache:masterfrom
zhaoyuguang:zhaoyuguang/fix-2473

Conversation

@zhaoyuguang
Copy link
Copy Markdown
Member

Please answer these questions before submitting pull request


Bug fix

  • it cannot get the ContextSnapshot object from the callback instance creates by Kafka framework.

  • How to fix?
    Extend HierarchyMatch, when class is specified inner class, no match.

@wu-sheng
Copy link
Copy Markdown
Member

Why add this exclusion to fix this issue? @ascrutae I don't expect to do in this way. Could you provide some helps about this bug fix?

@wu-sheng wu-sheng requested a review from ascrutae April 22, 2019 11:41
@wu-sheng
Copy link
Copy Markdown
Member

@zhaoyuguang I have talked with @ascrutae There are two things

  1. This issue has been fixed already, not elegant, but work.
  2. Your change will work(I think), but you don't change #buildJunction, which affect the byte-buddy core.
  3. Change HierarchyMatch makes the API more complex, I have doubts and concerns about the meaning of doing it. Because of (1), we have the method to fix.

Also, in current plugins, we haven't found anything else requires this. So, I suggest abandoning the change this time, and wait to see. @ascrutae supports me about this.

@wu-sheng wu-sheng added this to the 6.1.0 milestone Apr 22, 2019
@wu-sheng wu-sheng added wontfix This will not be worked on agent Language agent related. core feature Core and important feature. Sometimes, break backwards compatibility. labels Apr 22, 2019
@wu-sheng wu-sheng closed this Apr 22, 2019
@zhaoyuguang
Copy link
Copy Markdown
Member Author

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Language agent related. core feature Core and important feature. Sometimes, break backwards compatibility. wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants