Skip to content

Add unit tests for server-cluster-plugin module#2572

Merged
wu-sheng merged 2 commits intoapache:masterfrom
flycash:test-cluster-plugin
May 6, 2019
Merged

Add unit tests for server-cluster-plugin module#2572
wu-sheng merged 2 commits intoapache:masterfrom
flycash:test-cluster-plugin

Conversation

@flycash
Copy link
Copy Markdown
Member

@flycash flycash commented May 3, 2019

Add unit tests for cluster-consul, cluster-zookeeper, cluster-kubernetes

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Add unit tests

  • Related issues


Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented May 3, 2019

Submodules shouldn't be updated.

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented May 3, 2019

Please take a look at #2570 , and open multiple jdk and os versions, including the #2570 fix.
I want to check whether the tests could pass.

@wu-sheng wu-sheng added backend OAP backend related. test Test requirements about performance, feature or before release. labels May 3, 2019
@flycash flycash force-pushed the test-cluster-plugin branch from d8ff521 to 6ab92b6 Compare May 3, 2019 15:38
@flycash
Copy link
Copy Markdown
Member Author

flycash commented May 3, 2019

I think I need some help. I don't know why the change list contains the submodule because I only add some unit tests.
Can you give me some suggestions to solve the problem?

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented May 4, 2019

I think we update submodule to older version. From the latest to your local version.
Two ways,

  1. Read git document and update them again to master submodule commit id.
  2. Fork from master again.

2. Add unit tests for cluster-zookeeper-plugin;
3. Add unit tests for cluster-kubernetes-plugin;
@flycash flycash force-pushed the test-cluster-plugin branch from 6ab92b6 to 20b80cf Compare May 5, 2019 15:04
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 16.418% when pulling c3af428 on flycash:test-cluster-plugin into 683e048 on apache:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 16.418% when pulling c3af428 on flycash:test-cluster-plugin into 683e048 on apache:master.

@wu-sheng wu-sheng merged commit a4eb10d into apache:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. test Test requirements about performance, feature or before release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants