Add unit tests for server-cluster-plugin module#2572
Merged
wu-sheng merged 2 commits intoapache:masterfrom May 6, 2019
Merged
Conversation
Member
|
Submodules shouldn't be updated. |
Member
d8ff521 to
6ab92b6
Compare
Member
Author
|
I think I need some help. I don't know why the change list contains the submodule because I only add some unit tests. |
Member
|
I think we update submodule to older version. From the latest to your local version.
|
2. Add unit tests for cluster-zookeeper-plugin; 3. Add unit tests for cluster-kubernetes-plugin;
6ab92b6 to
20b80cf
Compare
1 similar comment
wu-sheng
approved these changes
May 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests for cluster-consul, cluster-zookeeper, cluster-kubernetes
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Add unit tests
Related issues
Bug fix
Bug description.
How to fix?
New feature or improvement