Rename metric and indicator to metrics.#2643
Merged
wu-sheng merged 3 commits intoapache:masterfrom May 10, 2019
Merged
Conversation
peng-yongsheng
added
documentation
Member
|
@kezhenxu94 This pr includes concept updates, a little related to the document. |
wu-sheng
reviewed
May 9, 2019
|
|
||
| public class Indicators { | ||
| private static Map<String, Class<? extends Indicator>> REGISTER = new HashMap<>(); | ||
| public class Metrics { |
Member
There was a problem hiding this comment.
Could we change this to MetricsHolder? I don't want to use full name below.
Member
|
Member
|
@flycash Please notice, We could add this bug after our k8s client upgrade later. |
wu-sheng
approved these changes
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we say our project is a observability system. It contains 3 core concept: Logging, Metrics, Tracing. So, we should unify the nouns of metrics.