-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Check disallowed imports in agent instrumentation classes #2908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wu-sheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check style module is being removed, right?
And do I still need that scripts to check? Could we remove that?
Yes, the module is just used for holding the
Removing it or not is both ok to me as long as it does no harm |
|
If you can remove, remove. Because we need consistent configuration in one place. With this PR, it shows in both places. |
done |
|
You are so fast @kezhenxu94 . I'm going to do it. |
wu-sheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you and @dmsolr to make this feature better.
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Enhancement
Related issues
As described in #2871 , we merged a PR that breaks the agent by importing external classes, and a script to check that is provided in #2881 , here I'm proposing another way to check this before our contributors commit and push their codes, by leveraging the checkstyle plugin, if the contributors have a checkstyle plugin installed in their IDE, it would show an error when writing codes, before submitting, which would save some time.