Closed
Conversation
Member
|
What is the difference between two basic images? |
Member
|
@JaredTan95 I think you should consider adding an e2e stage(parallel) to check the image we built in dev stage. |
Member
Author
|
Closed, temporarily. Other things need to be done. |
Contributor
|
Seems like there’s no `bash` in it. entrypoint script can not be executed.
… On Jul 3, 2019, at 2:49 PM, Jared Tan ***@***.***> wrote:
Closed, temporarily. Others need to be done.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#2992?email_source=notifications&email_token=AAO6UWIQQZQU2FYMUZMZTDLP5RDZFA5CNFSM4H5CLDD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZDOWOQ#issuecomment-507964218>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAO6UWJXYFHM7R6R4RX2E5LP5RDZFANCNFSM4H5CLDDQ>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
In my opinion, I think the final image is too big.
If there are no special requirements for the docker image, we can optimize it in some way.
Before:
After: