Conversation
|
|
||
| @Override | ||
| protected String[] witnessClasses() { | ||
| return new String[] {"org.apache.solr.servlet.BaseSolrServlet"}; |
There was a problem hiding this comment.
Do we need to add witness class for SolrJ plugin? I think you should run tests for Solr and SolrJ both.
There was a problem hiding this comment.
Yes, But SolrJ is a part of Solr. So we cannot find a class for witnessing.
There was a problem hiding this comment.
I just suggest, you should run test cases for both Solr and SolrJ, make sure nothing breaks.
There was a problem hiding this comment.
In testscase, they worked together and passed the tests.
wu-sheng
added
agent
|
Ref test case, SkyAPMTest/agent-auto-integration-testcases#78 |
|
What can I do for Agent plugins Test -Failure? |
nothing, don't be bothered by this, it's still under construction and the failure won't affect the merging process (if approved ), but the travis-ci failure affects, take a look why it fails :) |
|
Thank you for your answer. @kezhenxu94 |
|
Here is the test report and validate logs |
|
@dmsolr I noticed several versions fail, could you check the logs and feedback? |
|
Here is the test report and validate logs |
|
Ok. I run it again in local |
|
I ran the tests twice. The results are shown as below. It is all passed. The validate logs (SkyWalkingRobot provided) shown the failure because of
|
|
@ascrutae please help on checking the test cases. |
|
Could you help to run agent-plugin test agin? |
|
@dmsolr Have you fixed the issue? |
|
I cannot find out. So I think I need more information. |
|
Why you think rerun in test env could provide more inform than last time? |
|
I talked with @wu-sheng about it. This plugin may conflict with SolrJ. So we decided to give up. |
4 participants
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
[Agent] Provide plugin for Solr-7.x #2501