Fix wrong logger names#3075
Merged
wu-sheng merged 3 commits intoapache:masterfrom Jul 14, 2019
kezhenxu94:bugfix/logger-name
Merged
Fix wrong logger names#3075wu-sheng merged 3 commits intoapache:masterfrom kezhenxu94:bugfix/logger-name
wu-sheng merged 3 commits intoapache:masterfrom
kezhenxu94:bugfix/logger-name
Conversation
Member
@kezhenxu94 You could change this in OAP side, I am just saying, the check may be still necessary. |
Member
|
Are we going to merge this first? |
Member
Author
I've just fixed those in agent side, and can be merged first now. As for the check in CI, let me update the script and work on it in another PR |
Member
Author
|
/run e2e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
Logger name differentiate from the real class may be troublesome when debugging, and we have several pull requests that try to correct some of them (#3054), but not all of them.
So I just wrote a simple shell script to find out all such cases and fix them once and for all.
Since we are using
lombok, to avoid such problem in the future, I'd recommend using@Slf4jannotation in future PRs when possible.