Fixed a mistake that inject v1 segment producer into v2 standardizati…#3090
Merged
Conversation
peng-yongsheng
added
bug
wu-sheng
approved these changes
Jul 15, 2019
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
LGTM. @kezhenxu94 This is a good point we need e2e. This receiver is 100% tested by that. Super exciting.
Member
|
Just for the record, this bug wouldn't cause any issue, because of protobuf compatible design, and due to we don't change field sequence, but just field name, which is not used in protobuf serialization. |
Member
|
/run e2e |
1 similar comment
Member
|
/run e2e |
Member
|
Look like Jenkins has some issues, let's wait for a moment. |
Member
|
/run e2e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on worker.
Please answer these questions before submitting a pull request