Skip to content

OAP internal RemoteService protocol change and code refactor#3128

Merged
peng-yongsheng merged 8 commits intomasterfrom
workid2name
Jul 20, 2019
Merged

OAP internal RemoteService protocol change and code refactor#3128
peng-yongsheng merged 8 commits intomasterfrom
workid2name

Conversation

@wu-sheng
Copy link
Member

Remote nextWorkerId, streamDataId in OAP internal RemoteService, instead, I add nextWorkerName. Because, as OAL scripts have been moved in runtime, most likely, OAL scripts may be different in different OAP instances, which are wrong. But in old codes, this error can't identify clearly, due to we use the bootstrap sequence as integer IDs to do aggregations across OAP instances. It is hard to tell why the data structure of metrics or inventory is not matching.

By using string, OAL variable alias, it is clear and easy unique at global, when OAL scripts are not same, OAP gRPC handler could give a very clear warning.

logger.warn("Work name [{}] not found. Check OAL script, make sure they are same in the whole cluster.", nextWorkerName);

@wu-sheng wu-sheng requested a review from peng-yongsheng July 20, 2019 13:13
@wu-sheng wu-sheng added this to the 6.3.0 milestone Jul 20, 2019
@wu-sheng wu-sheng added core feature Core and important feature. Sometimes, break backwards compatibility. feature New feature backend OAP backend related. labels Jul 20, 2019
@wu-sheng
Copy link
Member Author

FYI @hanahmily this warning should be noticed.

@peng-yongsheng peng-yongsheng merged commit d256fc3 into master Jul 20, 2019
@wu-sheng wu-sheng deleted the workid2name branch July 20, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. core feature Core and important feature. Sometimes, break backwards compatibility. feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants