OAP internal RemoteService protocol change and code refactor#3128
Merged
peng-yongsheng merged 8 commits intomasterfrom Jul 20, 2019
Merged
OAP internal RemoteService protocol change and code refactor#3128peng-yongsheng merged 8 commits intomasterfrom
peng-yongsheng merged 8 commits intomasterfrom
Conversation
Member
Author
|
FYI @hanahmily this warning should be noticed. |
peng-yongsheng
approved these changes
Jul 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote nextWorkerId, streamDataId in OAP internal RemoteService, instead, I add nextWorkerName. Because, as OAL scripts have been moved in runtime, most likely, OAL scripts may be different in different OAP instances, which are wrong. But in old codes, this error can't identify clearly, due to we use the bootstrap sequence as integer IDs to do aggregations across OAP instances. It is hard to tell why the data structure of metrics or inventory is not matching.
By using string, OAL variable alias, it is clear and easy unique at global, when OAL scripts are not same, OAP gRPC handler could give a very clear warning.