Skip to content

Add more configuration and explainations.#3302

Merged
wu-sheng merged 6 commits intomasterfrom
agent_conf
Aug 22, 2019
Merged

Add more configuration and explainations.#3302
wu-sheng merged 6 commits intomasterfrom
agent_conf

Conversation

@JaredTan95
Copy link
Copy Markdown
Member

@JaredTan95 JaredTan95 commented Aug 22, 2019

Please answer these questions before submitting pull request

  • Why submit this pull request?
  • Bug fix
  • New feature provided
  • Improve performance

Show more frequently used configuration.

@JaredTan95 JaredTan95 requested a review from kezhenxu94 August 22, 2019 01:54
@JaredTan95 JaredTan95 added agent Language agent related. documentation Provide documents related issue or pull request only. labels Aug 22, 2019
@JaredTan95 JaredTan95 modified the milestones: 6.5.0, 6.4.0 Aug 22, 2019
@JaredTan95 JaredTan95 requested a review from wu-sheng August 22, 2019 01:54
kezhenxu94
kezhenxu94 reviewed Aug 22, 2019
View reviewed changes
kezhenxu94
kezhenxu94 previously approved these changes Aug 22, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaredTan95
Copy link
Copy Markdown
Member Author

JaredTan95 commented Aug 22, 2019 •
edited
Loading

And I also think, hold more frequently used configuration here, when users see those configurations, they know about the agent advanced features. Decrease the time of users look through documents.

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Aug 22, 2019

/run e2e

@kezhenxu94
Copy link
Copy Markdown
Member

kezhenxu94 commented Aug 22, 2019

@JaredTan95 The e2e test uses the default name Your_ApplicationName, and it's renamed by you to Your_ServiceName, making the tests failed, can you please change the test data as well?

skywalking/test/e2e/e2e-agent-reboot/src/test/resources/expected-data/org.apache.skywalking.e2e.SampleVerificationITCase.services.yml

Lines 20 to 25 in 49f50a2

# 1 create sequence
# 1 create table statement
services:
- key: 2
label: "Your_ApplicationName"

skywalking/test/e2e/e2e-single-service/src/test/resources/expected-data/org.apache.skywalking.e2e.SampleVerificationITCase.services.yml

Lines 21 to 25 in d1a521b

# 1 create table statement
services:
- key: 2
label: "Your_ApplicationName"

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Aug 22, 2019

I prefer don't change this. It has been there for a long time.

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Aug 22, 2019

Just revert the service name change should be better.

@JaredTan95
Copy link
Copy Markdown
Member Author

JaredTan95 commented Aug 22, 2019

ok

@JaredTan95
Copy link
Copy Markdown
Member Author

JaredTan95 commented Aug 22, 2019

/run e2e

@wu-sheng wu-sheng merged commit 6d94411 into master Aug 22, 2019
@wu-sheng wu-sheng deleted the agent_conf branch August 22, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@kezhenxu94 kezhenxu94 kezhenxu94 left review comments

Assignees

No one assigned

Labels

agent Language agent related. documentation Provide documents related issue or pull request only.

Projects

None yet

Milestone

6.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JaredTan95 @wu-sheng @kezhenxu94