Skip to content

Make sure the cluster register happens before streaming process. #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wu-sheng merged 2 commits into from
Sep 17, 2019
Merged

Make sure the cluster register happens before streaming process. #3471

wu-sheng merged 2 commits into from
Sep 17, 2019

Conversation

@wu-sheng
Copy link
Member

@wu-sheng wu-sheng commented Sep 16, 2019 •
edited
Loading

  1. Make sure cluster register in start stage, rather than after server(grpc/jetty) started.
  2. Add a warning log, rather than NPE, in case streaming calculation still happens caused by log cache file.

resolves #3402.

@wu-sheng wu-sheng added backend OAP backend related. feature New feature labels Sep 16, 2019
@wu-sheng wu-sheng added this to the 6.5.0 milestone Sep 16, 2019
@wu-sheng wu-sheng requested a review from hanahmily September 16, 2019 07:09
@wu-sheng
Copy link
Member Author

wu-sheng commented Sep 16, 2019

/run ci

hanahmily
hanahmily approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@hanahmily hanahmily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu-sheng wu-sheng merged commit 06c357d into master Sep 17, 2019
@wu-sheng wu-sheng deleted the boot-seq branch September 17, 2019 00:53
@wu-sheng wu-sheng mentioned this pull request Oct 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanahmily hanahmily hanahmily approved these changes

Assignees

No one assigned

Labels

backend OAP backend related. feature New feature

Projects

None yet

Milestone

6.5.0

Development

Successfully merging this pull request may close these issues.

More reasonable error output

2 participants

@wu-sheng @hanahmily