Skip to content

Language of instance could be NULL#3485

Merged
wu-sheng merged 3 commits intomasterfrom
fix-break
Sep 18, 2019
Merged

Language of instance could be NULL#3485
wu-sheng merged 3 commits intomasterfrom
fix-break

Conversation

@wu-sheng
Copy link
Copy Markdown
Member

@JaredTan95

We missed your #3367 breaks the system and e2e tests, we should wait for e2e passed(MUST). This PR fixes the Language could be NULL issue.

@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! core feature Core and important feature. Sometimes, break backwards compatibility. high priority High priority issue, blocking next release. labels Sep 18, 2019
@wu-sheng wu-sheng added this to the 6.5.0 milestone Sep 18, 2019
kezhenxu94
kezhenxu94 previously approved these changes Sep 18, 2019
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kezhenxu94 kezhenxu94 dismissed their stale review September 18, 2019 15:10

checkstyle failed

kezhenxu94
kezhenxu94 previously approved these changes Sep 18, 2019
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng
Copy link
Copy Markdown
Member Author

/run ci

@wu-sheng wu-sheng merged commit 6942ec8 into master Sep 18, 2019
@wu-sheng wu-sheng deleted the fix-break branch September 18, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working and you are sure it's a bug! core feature Core and important feature. Sometimes, break backwards compatibility. high priority High priority issue, blocking next release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants