Skip to content

Conversation

@x22x22
Copy link
Member

@x22x22 x22x22 commented Sep 22, 2019

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues


Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

add query server timestamp and timezone info

@kezhenxu94 kezhenxu94 added this to the 6.5.0 milestone Sep 22, 2019
@kezhenxu94 kezhenxu94 added the UI UI and front end related. label Sep 22, 2019
kezhenxu94
kezhenxu94 previously approved these changes Sep 22, 2019
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng
Copy link
Member

Submodule doesn't update.

@wu-sheng wu-sheng removed the UI UI and front end related. label Sep 22, 2019
@wu-sheng wu-sheng mentioned this pull request Sep 22, 2019
3 tasks
TimeInfo timeInfo = new TimeInfo();
SimpleDateFormat timezoneFormat = new SimpleDateFormat("ZZZZZZ");
Date date = new Date();
timeInfo.setCurrentTimestamp(date.getTime());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref https://stackoverflow.com/questions/368094/system-currenttimemillis-vs-new-date-vs-calendar-getinstance-gettime

System.currentTimeMillis() should be faster and good enough. Right?

Copy link
Member Author

@x22x22 x22x22 Sep 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do get the timezone?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I miss that.

@wu-sheng
Copy link
Member

@kezhenxu94 Look like some rule causing this auto labeling failure.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 058335f into apache:master Sep 22, 2019
@x22x22 x22x22 deleted the query-server-time-info branch September 22, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants