-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Query server time info #3498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query server time info #3498
Conversation
# Conflicts: # skywalking-ui
kezhenxu94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Submodule doesn't update. |
| TimeInfo timeInfo = new TimeInfo(); | ||
| SimpleDateFormat timezoneFormat = new SimpleDateFormat("ZZZZZZ"); | ||
| Date date = new Date(); | ||
| timeInfo.setCurrentTimestamp(date.getTime()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System.currentTimeMillis() should be faster and good enough. Right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do get the timezone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I miss that.
|
@kezhenxu94 Look like some rule causing this auto labeling failure. |
wu-sheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
Bug fix
Bug description.
How to fix?
New feature or improvement
add query server timestamp and timezone info