Skip to content

Delete unused code.#4178

Merged
wu-sheng merged 1 commit intomasterfrom
unknown repository
Jan 6, 2020
Merged

Delete unused code.#4178
wu-sheng merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jan 6, 2020

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues


Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

@codecov-io
Copy link

Codecov Report

Merging #4178 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4178      +/-   ##
==========================================
- Coverage   26.82%   26.77%   -0.05%     
==========================================
  Files        1163     1163              
  Lines       25428    25426       -2     
  Branches     3691     3691              
==========================================
- Hits         6820     6807      -13     
- Misses      18000    18013      +13     
+ Partials      608      606       -2
Impacted Files Coverage Δ
.../java/org/apache/skywalking/oal/rt/OALRuntime.java 0% <ø> (ø) ⬆️
.../core/remote/ServiceAndEndpointRegisterClient.java 31.46% <0%> (-13.49%) ⬇️
...walking/apm/agent/core/context/TracingContext.java 58.2% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b15e6...ac9ffa5. Read the comment docs.

@wayilau wayilau added the backend OAP backend related. label Jan 6, 2020
@wayilau wayilau added this to the 7.0.0 milestone Jan 6, 2020
Copy link
Member

@wayilau wayilau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused, indeed.

@wu-sheng wu-sheng merged commit f181f7b into apache:master Jan 6, 2020
@ghost ghost deleted the d branch January 6, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants