Skip to content

Close inputstream.#4184

Merged
kezhenxu94 merged 3 commits intoapache:masterfrom
wayilau:fix1
Jan 7, 2020
Merged

Close inputstream.#4184
kezhenxu94 merged 3 commits intoapache:masterfrom
wayilau:fix1

Conversation

@wayilau
Copy link
Member

@wayilau wayilau commented Jan 6, 2020

Please answer these questions before submitting pull request

  • Why submit this pull request?
  • Bug fix
  • New feature provided
  • Improve performance

Close the inpustream.

@wayilau wayilau added the plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. label Jan 6, 2020
@wayilau wayilau added this to the 7.0.0 milestone Jan 6, 2020
@wayilau wayilau added the bug Something isn't working and you are sure it's a bug! label Jan 6, 2020
@wayilau wayilau requested a review from wu-sheng January 6, 2020 09:47
@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #4184 into master will decrease coverage by 0.02%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4184      +/-   ##
==========================================
- Coverage   26.84%   26.81%   -0.03%     
==========================================
  Files        1163     1163              
  Lines       25426    25427       +1     
  Branches     3691     3692       +1     
==========================================
- Hits         6826     6819       -7     
- Misses      17991    17998       +7     
- Partials      609      610       +1
Impacted Files Coverage Δ
...alking/apm/agent/core/remote/AgentIDDecorator.java 85.71% <87.5%> (-3.18%) ⬇️
...apm/agent/core/remote/GRPCStreamServiceStatus.java 29.16% <0%> (-25.01%) ⬇️
.../agent/core/context/trace/AbstractTracingSpan.java 60.36% <0%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f181f7b...3dacda9. Read the comment docs.

@kezhenxu94 kezhenxu94 merged commit b1b1615 into apache:master Jan 7, 2020
@wayilau wayilau deleted the fix1 branch January 7, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working and you are sure it's a bug! plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants