Skip to content

Fix typo: Update maven update command and description#4241

Closed
JohnNiang wants to merge 3 commits into
apache:masterfrom
JohnNiang:master
Closed

Fix typo: Update maven update command and description#4241
JohnNiang wants to merge 3 commits into
apache:masterfrom
JohnNiang:master

Conversation

@JohnNiang
Copy link
Copy Markdown
Contributor

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues


Bug fix

  • Bug description.

typo fix.

  • How to fix?

Replace with maven wrapper command and fix compile typo.


New feature or improvement

  • Describe the details and related test reports.

@JohnNiang JohnNiang requested a review from JaredTan95 January 16, 2020 02:58
@JaredTan95 JaredTan95 added this to the 7.0.0 milestone Jan 16, 2020
@JaredTan95 JaredTan95 added the documentation Provide documents related issue or pull request only. label Jan 16, 2020
Comment thread docs/en/guides/How-to-build.md Outdated
@JohnNiang JohnNiang closed this Jan 16, 2020
@wu-sheng
Copy link
Copy Markdown
Member

You don't need to close, the compile is really a typo. Just don't change this command.

@wu-sheng wu-sheng reopened this Jan 16, 2020
@wu-sheng
Copy link
Copy Markdown
Member

I revert that part of the change for you. compile should be compiling.

@JohnNiang
Copy link
Copy Markdown
Contributor Author

Thank you for rectification.

@JaredTan95
Copy link
Copy Markdown
Member

199th contributor~

@wu-sheng
Copy link
Copy Markdown
Member

199th contributor~

Yes, we are closing the 200th. Who will own the honor? :)

@wu-sheng
Copy link
Copy Markdown
Member

Strange, a markdown change makes the CI unstable...

@wu-sheng
Copy link
Copy Markdown
Member

Is there anything wrong about downloading JDBC driver?

@JaredTan95
Copy link
Copy Markdown
Member

I re-run the ci.

@wu-sheng
Copy link
Copy Markdown
Member

I re-run the ci.

All errors are about no suitable driver of MySQL, but it should be downloaded in CI process.

@JaredTan95
Copy link
Copy Markdown
Member

[ERROR] Failed to execute goal io.fabric8:docker-maven-plugin:0.30.0:start (start) on project e2e-mysql: I/O Error: [skyapm/e2e-container:jdk8-1.3] "skywalking-e2e-container-local-single-node-mysql": Timeout after 300399 ms while waiting on url http://localhost:32771/e2e/health-check -> [Help 1]

It looks like oap server container stared failed...

@JaredTan95
Copy link
Copy Markdown
Member

@JohnNiang you delete your fork? I noted unknown repository

@JohnNiang
Copy link
Copy Markdown
Contributor Author

@JohnNiang you delete your fork? I noted unknown repository

I will re-request this PR soon.

@JohnNiang JohnNiang closed this Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Provide documents related issue or pull request only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants