Make traces verification loosely, stabilize e2e tests#4306
Merged
Conversation
kezhenxu94
added
the
test
3 tasks
### Motivation: Make E2E tests more stable. ### Modifications: Verify the traces loosely as other tests, and remove the `verify` method which verifies traces strictly, as we have preparation that also generates traces. ### Result: E2E tests are more stable.
Codecov Report
@@ Coverage Diff @@
## master #4306 +/- ##
==========================================
+ Coverage 26.8% 26.81% +<.01%
==========================================
Files 1170 1170
Lines 25577 25577
Branches 3655 3655
==========================================
+ Hits 6857 6859 +2
+ Misses 18111 18108 -3
- Partials 609 610 +1
Continue to review full report at Codecov.
|
wu-sheng
approved these changes
Feb 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Make E2E tests more stable.
Modifications:
verifymethod which verifies traces strictly, as we have preparation that also generates traces.--batch-modeto get rid of the downloading progress.Result:
E2E tests are more stable.