Clean up legacy v1 header logic, use built-in Base64 since JDK8#4307
Merged
Conversation
kezhenxu94
added
agent
kezhenxu94
commented
Feb 2, 2020
wu-sheng
reviewed
Feb 2, 2020
Member
|
Many CI processes fail. Please recheck. |
### Motivation: Codes clean up ### Modifications: - Remove v1 header, follow up #4244 - Use built-in Base64 class (since JDK8) ### Result: - No more legacy v1 headers - No unnecessary codes concerns by using built-in ability
wu-sheng
approved these changes
Feb 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Codes clean up
Modifications:
Remove v1 header, follow up Drop support of protocol v1 (sw3) #4244
Use built-in Base64 class (since JDK8)
Result:
No more legacy v1 headers
No unnecessary codes concerns by using built-in ability