Add Armeria 0.98.0 to the supported version list #4328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrproliu
added
agent
wu-sheng
approved these changes
Feb 8, 2020
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
Waiting for auto tests only.
wu-sheng
reviewed
Feb 8, 2020
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
FYI @kezhenxu94 In the latest 0.98 Armeria test, seems the context propagation breaks. Could you recheck?
wu-sheng
reviewed
Feb 8, 2020
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
Latest 0.98 Armeria can't pass the test.
wu-sheng
previously requested changes
Feb 8, 2020
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
Request @kezhenxu94 recheck the plugin
kezhenxu94
dismissed
wu-sheng’s stale review
Requested changes are addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @wu-sheng 😉