Add 200000 microsecond sleep in E2E-PHP#4582
Merged
wu-sheng merged 15 commits intoapache:masterfrom Mar 28, 2020
heyanlong:master
Merged
Add 200000 microsecond sleep in E2E-PHP#4582wu-sheng merged 15 commits intoapache:masterfrom heyanlong:master
wu-sheng merged 15 commits intoapache:masterfrom
heyanlong:master
Conversation
wu-sheng
approved these changes
Mar 28, 2020
wu-sheng
added
the
test
Member
|
why sleep so long unnecessarily? This will slow down the checks drastically |
Member
Author
simulation 200ms processing time |
Member
Your title is misleading, which says 200000ms=200s=~2minutes |
Member
|
@kezhenxu94 I think the title is microsecond, not ms, which usually is meaning millionseconds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
Bug fix
Bug description.
How to fix?
New feature or improvement