Skip to content

Conversation

@wu-sheng
Copy link
Member

@wu-sheng wu-sheng commented Jun 8, 2020

Follow #4783

Fix a missing link
@wu-sheng wu-sheng added the documentation Provide documents related issue or pull request only. label Jun 8, 2020
@wu-sheng wu-sheng added this to the 8.0.0 milestone Jun 8, 2020
@wu-sheng wu-sheng requested a review from a team June 8, 2020 02:17
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #4870 into master will increase coverage by 1.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4870      +/-   ##
============================================
+ Coverage     49.83%   51.20%   +1.37%     
- Complexity     2736     2740       +4     
============================================
  Files           762     1342     +580     
  Lines         18850    29327   +10477     
  Branches       1852     3237    +1385     
============================================
+ Hits           9393    15016    +5623     
- Misses         8706    13600    +4894     
+ Partials        751      711      -40     
Impacted Files Coverage Δ Complexity Δ
...erver/receiver/envoy/MetricServiceGRPCHandler.java 12.16% <0.00%> (-77.84%) 2.00% <0.00%> (ø%)
...er/receiver/envoy/AccessLogServiceGRPCHandler.java 20.75% <0.00%> (-37.15%) 2.00% <0.00%> (ø%)
...skywalking/oap/server/core/alarm/AlarmMessage.java 66.66% <0.00%> (-33.34%) 2.00% <0.00%> (ø%)
...ient/elasticsearch/ElasticSearchInsertRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ient/elasticsearch/ElasticSearchUpdateRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ticsearch7/client/ElasticSearch7UpdateRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ticsearch7/client/ElasticSearch7InsertRequest.java 83.33% <0.00%> (-16.67%) 2.00% <0.00%> (ø%)
...erver/core/analysis/data/MergableBufferedData.java 84.61% <0.00%> (-15.39%) 4.00% <0.00%> (ø%)
...server/core/analysis/worker/AlarmNotifyWorker.java 85.71% <0.00%> (-14.29%) 3.00% <0.00%> (ø%)
.../server/core/analysis/data/ReadWriteSafeCache.java 68.18% <0.00%> (-10.77%) 3.00% <0.00%> (ø%)
... and 904 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0f39f...38d65aa. Read the comment docs.

Copy link
Contributor

@hanahmily hanahmily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 98e29a6 into master Jun 8, 2020
@wu-sheng wu-sheng deleted the wu-sheng-patch-1 branch June 8, 2020 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Provide documents related issue or pull request only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants