Skip to content

Conversation

@wu-sheng
Copy link
Member

@wu-sheng wu-sheng commented Jun 8, 2020

With the UI closing to the final version, I could finish all configurations and add the default templates.

image

image

image

@wu-sheng wu-sheng added core feature Core and important feature. Sometimes, break backwards compatibility. backend OAP backend related. UI UI and front end related. labels Jun 8, 2020
@wu-sheng wu-sheng added this to the 8.0.0 milestone Jun 8, 2020
@wu-sheng wu-sheng requested review from a team, ascrutae and hanahmily June 8, 2020 13:18
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #4876 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4876      +/-   ##
============================================
+ Coverage     50.70%   50.82%   +0.12%     
- Complexity     2708     2712       +4     
============================================
  Files          1342     1342              
  Lines         29328    29327       -1     
  Branches       3237     3239       +2     
============================================
+ Hits          14870    14905      +35     
+ Misses        13749    13704      -45     
- Partials        709      718       +9     
Impacted Files Coverage Δ Complexity Δ
...er/storage/plugin/influxdb/base/ManagementDAO.java 80.00% <100.00%> (+56.19%) 3.00 <0.00> (+1.00)
.../skywalking/apm/agent/core/remote/GRPCChannel.java 81.81% <0.00%> (-6.07%) 5.00% <0.00%> (-1.00%)
...agent/core/context/OperationNameFormatService.java 21.73% <0.00%> (-4.35%) 5.00% <0.00%> (-1.00%)
...skywalking/apm/agent/core/boot/ServiceManager.java 66.17% <0.00%> (-1.48%) 15.00% <0.00%> (-1.00%)
...ng/oap/server/core/alarm/provider/RunningRule.java 77.08% <0.00%> (-0.53%) 10.00% <0.00%> (ø%)
...rg/apache/skywalking/apm/agent/core/os/OSUtil.java 69.49% <0.00%> (ø) 12.00% <0.00%> (ø%)
...apm/agent/core/remote/GRPCStreamServiceStatus.java 80.95% <0.00%> (ø) 6.00% <0.00%> (ø%)
.../agent/core/profile/ProfileTaskChannelService.java 45.05% <0.00%> (ø) 9.00% <0.00%> (ø%)
...skywalking/oap/server/core/CoreModuleProvider.java 79.72% <0.00%> (+1.39%) 9.00% <0.00%> (+1.00%)
...ache/skywalking/apm/agent/core/jvm/JVMService.java 84.74% <0.00%> (+3.38%) 7.00% <0.00%> (ø%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0274d...f813ad9. Read the comment docs.

ascrutae
ascrutae previously approved these changes Jun 8, 2020
@wu-sheng
Copy link
Member Author

wu-sheng commented Jun 8, 2020

@dmsolr Seems the template initialization makes all InfluxDB related e2e cases fail. Please help.

Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 0c1b8e4 into master Jun 9, 2020
@wu-sheng wu-sheng deleted the default-template branch June 9, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. core feature Core and important feature. Sometimes, break backwards compatibility. UI UI and front end related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants