Skip to content

Conversation

@yu199195
Copy link
Member

Please answer these questions before submitting pull request

  • Why submit this pull request?
  • Bug fix
  • New feature provided
  • Improve performance

@JaredTan95
Copy link
Member

You can move this change into #4894 one PR.

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #4900 into master will decrease coverage by 1.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4900      +/-   ##
============================================
- Coverage     51.22%   50.21%   -1.01%     
- Complexity     2740     2744       +4     
============================================
  Files          1341      759     -582     
  Lines         29296    18814   -10482     
  Branches       3232     1846    -1386     
============================================
- Hits          15007     9448    -5559     
+ Misses        13580     8604    -4976     
- Partials        709      762      +53     
Impacted Files Coverage Δ Complexity Δ
...p/server/core/analysis/metrics/MinLongMetrics.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...er/exporter/provider/grpc/GRPCExporterSetting.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...server/library/util/prometheus/metrics/Metric.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...king/oap/server/configuration/api/ConfigTable.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...er/library/util/prometheus/metrics/MetricType.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...library/util/prometheus/parser/sample/Context.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...skywalking/oap/server/receiver/envoy/als/Role.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
.../server/receiver/envoy/als/DependencyResource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...cher/prometheus/provider/rule/CounterFunction.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
... and 907 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df83490...91f4757. Read the comment docs.

@yu199195 yu199195 closed this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants