Skip to content

Conversation

@wu-sheng
Copy link
Member

As UI supports the bar and area graph, besides the line chart, I changed the count graph to bar style. Because by using this, the count could be added as one entity.

image

@wu-sheng wu-sheng added backend OAP backend related. UI UI and front end related. enhancement Enhancement on performance or codes labels Jun 19, 2020
@wu-sheng wu-sheng added this to the 8.1.0 milestone Jun 19, 2020
@wu-sheng wu-sheng requested review from a team and hanahmily June 19, 2020 02:37
Copy link
Contributor

@hanahmily hanahmily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #4947 into master will increase coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4947      +/-   ##
============================================
+ Coverage     50.31%   51.33%   +1.01%     
+ Complexity     2754     2746       -8     
============================================
  Files           761     1354     +593     
  Lines         18865    29470   +10605     
  Branches       1851     3258    +1407     
============================================
+ Hits           9492    15128    +5636     
- Misses         8614    13617    +5003     
+ Partials        759      725      -34     
Impacted Files Coverage Δ Complexity Δ
...s/manual/database/DatabaseStatementDispatcher.java 10.00% <0.00%> (-90.00%) 1.00% <0.00%> (-1.00%)
...erver/receiver/envoy/MetricServiceGRPCHandler.java 12.16% <0.00%> (-77.84%) 2.00% <0.00%> (ø%)
...er/receiver/envoy/AccessLogServiceGRPCHandler.java 20.75% <0.00%> (-37.15%) 2.00% <0.00%> (ø%)
...skywalking/oap/server/core/alarm/AlarmMessage.java 66.66% <0.00%> (-33.34%) 2.00% <0.00%> (ø%)
...skywalking/oap/server/core/analysis/topn/TopN.java 0.00% <0.00%> (-33.34%) 0.00% <0.00%> (-1.00%)
...ient/elasticsearch/ElasticSearchInsertRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ient/elasticsearch/ElasticSearchUpdateRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ticsearch7/client/ElasticSearch7UpdateRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ticsearch7/client/ElasticSearch7InsertRequest.java 83.33% <0.00%> (-16.67%) 2.00% <0.00%> (ø%)
...erver/core/analysis/data/MergableBufferedData.java 84.61% <0.00%> (-15.39%) 4.00% <0.00%> (ø%)
... and 922 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5971ae...9cfec38. Read the comment docs.

@wu-sheng wu-sheng merged commit 8c2c50b into master Jun 19, 2020
@wu-sheng wu-sheng deleted the introduce-barchart branch June 19, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. enhancement Enhancement on performance or codes UI UI and front end related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants