Skip to content

Conversation

@wu-sheng
Copy link
Member

  1. Fix endpoint dependency bug in MQ and uninstrumented proxy cases. The new MultiScopesAnalysisListenerTest is really helpful on locating this complex analysis issue.
  2. Support endpoint dependency(v2 of endpoint topology case).

New graphql query

{
  getEndpointDependencies(
    endpointId: "bW9ja19iX3NlcnZpY2U=.1_b3JnLnNreXdha2luZy5hcG0udGVzdGNhc2UuZHViYm8uc2VydmljZXMuR3JlZXRTZXJ2aWNlSW1wbC5kb0J1c2luZXNzKCk=",
  duration: {step:MINUTE, start: "2020-06-30 1750", end: "2020-06-30 1850"}
  ) {
    nodes {
      id,
      name,
      serviceId,
      serviceName,
      type,
      isReal
    },
    calls{
      id,
      source,
      target,
      detectPoints
    }
  }
}
{
  "data": {
    "getEndpointDependencies": {
      "nodes": [
        {
          "id": "bW9ja19hX3NlcnZpY2U=.1_L2R1YmJveC1jYXNlL2Nhc2UvZHViYm94LXJlc3Q=",
          "name": "/dubbox-case/case/dubbox-rest",
          "serviceId": "bW9ja19hX3NlcnZpY2U=.1",
          "serviceName": "mock_a_service",
          "type": "",
          "isReal": true
        },
        {
          "id": "bW9ja19iX3NlcnZpY2U=.1_b3JnLnNreXdha2luZy5hcG0udGVzdGNhc2UuZHViYm8uc2VydmljZXMuR3JlZXRTZXJ2aWNlSW1wbC5kb0J1c2luZXNzKCk=",
          "name": "org.skywaking.apm.testcase.dubbo.services.GreetServiceImpl.doBusiness()",
          "serviceId": "bW9ja19iX3NlcnZpY2U=.1",
          "serviceName": "mock_b_service",
          "type": "",
          "isReal": true
        },
        {
          "id": "bW9ja19jX3NlcnZpY2U=.1_b3JnLmFwYWNoZS5za3l3YWxraW5nLlJvY2tldE1R",
          "name": "org.apache.skywalking.RocketMQ",
          "serviceId": "bW9ja19jX3NlcnZpY2U=.1",
          "serviceName": "mock_c_service",
          "type": "",
          "isReal": true
        }
      ],
      "calls": [
        {
          "id": "bW9ja19hX3NlcnZpY2U=.1-L2R1YmJveC1jYXNlL2Nhc2UvZHViYm94LXJlc3Q=-bW9ja19iX3NlcnZpY2U=.1-b3JnLnNreXdha2luZy5hcG0udGVzdGNhc2UuZHViYm8uc2VydmljZXMuR3JlZXRTZXJ2aWNlSW1wbC5kb0J1c2luZXNzKCk=",
          "source": "bW9ja19hX3NlcnZpY2U=.1_L2R1YmJveC1jYXNlL2Nhc2UvZHViYm94LXJlc3Q=",
          "target": "bW9ja19iX3NlcnZpY2U=.1_b3JnLnNreXdha2luZy5hcG0udGVzdGNhc2UuZHViYm8uc2VydmljZXMuR3JlZXRTZXJ2aWNlSW1wbC5kb0J1c2luZXNzKCk=",
          "detectPoints": [
            "SERVER"
          ]
        },
        {
          "id": "bW9ja19iX3NlcnZpY2U=.1-b3JnLnNreXdha2luZy5hcG0udGVzdGNhc2UuZHViYm8uc2VydmljZXMuR3JlZXRTZXJ2aWNlSW1wbC5kb0J1c2luZXNzKCk=-bW9ja19jX3NlcnZpY2U=.1-b3JnLmFwYWNoZS5za3l3YWxraW5nLlJvY2tldE1R",
          "source": "bW9ja19iX3NlcnZpY2U=.1_b3JnLnNreXdha2luZy5hcG0udGVzdGNhc2UuZHViYm8uc2VydmljZXMuR3JlZXRTZXJ2aWNlSW1wbC5kb0J1c2luZXNzKCk=",
          "target": "bW9ja19jX3NlcnZpY2U=.1_b3JnLmFwYWNoZS5za3l3YWxraW5nLlJvY2tldE1R",
          "detectPoints": [
            "SERVER"
          ]
        }
      ]
    }
  }
}

… support endpoint dependency(v2 of endpoint topology case).
@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! backend OAP backend related. feature New feature labels Jun 30, 2020
@wu-sheng wu-sheng added this to the 8.1.0 milestone Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #4995 into master will decrease coverage by 2.86%.
The diff coverage is 17.39%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4995      +/-   ##
============================================
- Coverage     53.51%   50.65%   -2.87%     
+ Complexity     2941     2751     -190     
============================================
  Files          1394     1392       -2     
  Lines         30265    30267       +2     
  Branches       3374     3382       +8     
============================================
- Hits          16197    15332     -865     
- Misses        13268    14133     +865     
- Partials        800      802       +2     
Impacted Files Coverage Δ Complexity Δ
...ng/oap/server/core/query/TopologyQueryService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lking/oap/server/core/query/type/EndpointNode.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...g/oap/server/core/query/type/EndpointTopology.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...king/oap/query/graphql/resolver/TopologyQuery.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...r/parser/listener/MultiScopesAnalysisListener.java 85.55% <100.00%> (-1.04%) 18.00 <0.00> (-6.00)
.../trace/provider/parser/listener/SourceBuilder.java 95.27% <100.00%> (-0.63%) 15.00 <0.00> (-1.00)
...orage/plugin/elasticsearch7/dao/MetricsEs7DAO.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...orage/plugin/elasticsearch7/dao/StorageEs7DAO.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...lugin/elasticsearch7/base/StorageEs7Installer.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54a43c4...224a529. Read the comment docs.

@wu-sheng wu-sheng merged commit ea6be5b into master Jun 30, 2020
@wu-sheng wu-sheng deleted the endpoint-dependencies branch June 30, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. bug Something isn't working and you are sure it's a bug! feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants