Skip to content

Conversation

@zhaoyuguang
Copy link
Member

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #5009 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5009      +/-   ##
============================================
+ Coverage     52.80%   52.83%   +0.03%     
- Complexity     2916     2919       +3     
============================================
  Files          1400     1400              
  Lines         30421    30415       -6     
  Branches       3389     3389              
============================================
+ Hits          16064    16071       +7     
+ Misses        13555    13543      -12     
+ Partials        802      801       -1     
Impacted Files Coverage Δ Complexity Δ
...meter/function/AvgHistogramPercentileFunction.java 61.76% <0.00%> (-0.74%) 20.00% <0.00%> (-1.00%)
...ng/oap/server/core/alarm/provider/RunningRule.java 77.60% <0.00%> (+0.52%) 10.00% <0.00%> (ø%)
...skywalking/apm/agent/core/boot/ServiceManager.java 67.64% <0.00%> (+1.47%) 16.00% <0.00%> (+1.00%)
...apm/agent/core/remote/ServiceManagementClient.java 98.11% <0.00%> (+1.88%) 10.00% <0.00%> (ø%)
...g/oap/server/telemetry/prometheus/BaseMetrics.java 87.09% <0.00%> (+3.22%) 9.00% <0.00%> (+1.00%)
...in/elasticsearch7/client/ElasticSearch7Client.java 64.81% <0.00%> (+3.70%) 18.00% <0.00%> (+1.00%)
...core/plugin/bytebuddy/AnnotationTypeNameMatch.java 100.00% <0.00%> (+42.85%) 0.00% <0.00%> (ø%)
...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java 100.00% <0.00%> (+50.00%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1817386...ad804c6. Read the comment docs.

### Resolve

* When using `Thread Schedule Framework`
Checked SkyWalking Thread Schedule Framework at [SkyWalking Java agent supported list](../setup/service-agent/java-agent/Supported-list.md), such as Spring FrameWork @Async, such as Spring @Async, which can implement tracing without any modification.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Checked SkyWalking Thread Schedule Framework at [SkyWalking Java agent supported list](../setup/service-agent/java-agent/Supported-list.md), such as Spring FrameWork @Async, such as Spring @Async, which can implement tracing without any modification.
Checked SkyWalking Thread Schedule Framework at [SkyWalking Java agent supported list](../setup/service-agent/java-agent/Supported-list.md), such as Spring FrameWork @Async, which can implement tracing without any modification.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@wu-sheng wu-sheng added this to the 8.1.0 milestone Jul 1, 2020
@wu-sheng wu-sheng added the documentation Provide documents related issue or pull request only. label Jul 1, 2020
@wu-sheng
Copy link
Member

wu-sheng commented Jul 2, 2020

InfluxDB e2e has a little issue, I have informed @dmsolr. If those fail, still merge the PR, please.

@wu-sheng wu-sheng merged commit 00619a9 into apache:master Jul 2, 2020
@wu-sheng wu-sheng linked an issue Jul 2, 2020 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Provide documents related issue or pull request only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Java agent memory leak when enhance Worker thread at use Thread Pool

2 participants