Skip to content

Conversation

@Ax1an
Copy link
Member

@Ax1an Ax1an commented Jul 16, 2020

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues


Bug fix

  • Bug description.

    Fix NodeType.java note.

  • How to fix?

    Fix NodeType.java note.


New feature or improvement

  • Describe the details and related test reports.

@kezhenxu94 kezhenxu94 added the documentation Provide documents related issue or pull request only. label Jul 16, 2020
@kezhenxu94 kezhenxu94 added this to the 8.1.0 milestone Jul 16, 2020
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #5108 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5108      +/-   ##
============================================
- Coverage     53.15%   53.09%   -0.07%     
- Complexity     2989     2990       +1     
============================================
  Files          1416     1416              
  Lines         30674    30680       +6     
  Branches       3416     3416              
============================================
- Hits          16306    16289      -17     
- Misses        13567    13586      +19     
- Partials        801      805       +4     
Impacted Files Coverage Δ Complexity Δ
.../skywalking/oap/server/core/analysis/NodeType.java 54.54% <ø> (ø) 7.00 <0.00> (ø)
...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java 50.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
...core/plugin/bytebuddy/AnnotationTypeNameMatch.java 57.14% <0.00%> (-42.86%) 0.00% <0.00%> (ø%)
...r/cluster/plugin/standalone/StandaloneManager.java 77.77% <0.00%> (-22.23%) 3.00% <0.00%> (-1.00%)
...rary/client/elasticsearch/ElasticSearchClient.java 56.21% <0.00%> (-5.95%) 23.00% <0.00%> (-2.00%)
.../agent/core/context/trace/AbstractTracingSpan.java 66.35% <0.00%> (-2.81%) 13.00% <0.00%> (ø%)
...ng/oap/server/core/alarm/provider/RunningRule.java 77.08% <0.00%> (-0.53%) 10.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0339889...5ba903b. Read the comment docs.

@wu-sheng wu-sheng merged commit 7b9cbe2 into apache:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Provide documents related issue or pull request only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants